User talk:Fish bowl/zhRedirect.js

From Wiktionary, the free dictionary
Latest comment: 6 years ago by Suzukaze-c
Jump to navigation Jump to search

@Dixtosa If it isn't too much trouble, could you review this code? I'm not good at JavaScript. It's a response to this post, but I don't want to let other people use a shitty script. —suzukaze (tc) 02:45, 20 September 2017 (UTC)Reply

It looks ok (except for the lines you have marked //temp. Just add explicit dependencies for mw.util, mw.cookie, mw.notify. Also you can replace all the let's with var's if you want to reach more users. let is an ES6 construct and some very old browsers do not support it. I personally do not care about those users who do not update their browsers tho.--Giorgi Eufshi (talk) 08:55, 20 September 2017 (UTC)Reply
Just making sure, adding explicit dependencies is done using mw.loader.using, right? —suzukaze (tc) 01:45, 21 September 2017 (UTC)Reply