Wiktionary talk:Table of votes

From Wiktionary, the free dictionary
Latest comment: 7 years ago by Daniel Carrero in topic The Table is Broken
Jump to navigation Jump to search

cool[edit]

This is really cool. Kind of long though, and no scrollbar appears for me to move left or right. -Xbony2 (talk) 01:02, 23 August 2016 (UTC)Reply

Thank you! I don't suppose you are using a mobile phone? In my Firefox and Chrome, the usual horizontal scrollbar was appearing normally.
Anyway, I tried turning all user names 90° now. See if it looks better in your opinion. --Daniel Carrero (talk) 01:23, 23 August 2016 (UTC)Reply
I failed at trying to rotate the names 90°. "-moz-transform:rotate(270deg)" / "-webkit-transform" messed up white space and column width. "writing-mode" + "text-orientation" actually looked good on Firefox but does not seem to be supported by Chrome. --Daniel Carrero (talk) 14:51, 23 August 2016 (UTC)Reply
I'm on Safari (desktop) -Xbony2 (talk) 15:48, 23 August 2016 (UTC)Reply
@Xbony2: Fixed. I reoriented the table per a BP discussion. Does it look better now? --Daniel Carrero (talk) 22:27, 23 August 2016 (UTC)Reply
Yep, looks good ^_^ -Xbony2 (talk) 22:30, 23 August 2016 (UTC)Reply

The Table is Broken[edit]

@Daniel Carrero, there is a module error that is preventing the table from displaying. Apparently it's run out of time? Andrew Sheedy (talk) 03:49, 30 August 2016 (UTC)Reply

I tried doing a hard purge, to no avail. I don't know what else I could do in short notice. Presumably, if there were fewer vote pages, the page would load correctly, so we can wait for a few more votes to end and remove them from the list.
Incidentally, getting the contents of a separate page is an expensive function. Module:votes gets the content of each vote page multiple times to perform various tests. If we changed the module so that it gets the contents from each vote page just once and filled an array with the contents for future use, then probably the module error would cease to happen. I can try doing it later. --Daniel Carrero (talk) 04:00, 30 August 2016 (UTC)Reply
I changed the module according to my hypothesis above and it didn't work. But reducing the number of listed votes does make the list show up normally. I suppose we can only wait for a few votes to end before using the table again. --Daniel Carrero (talk) 06:11, 30 August 2016 (UTC)Reply
@Andrew Sheedy: One vote ended, so there are 13 votes now. The table is working again! --Daniel Carrero (talk) 03:06, 31 August 2016 (UTC)Reply
Not for me. :( (There haven't been any votes added since you posted that, have there?) Andrew Sheedy (talk) 13:53, 31 August 2016 (UTC)Reply
FYI: When you created this discussion, there were 14 votes in the table. Later, 1 vote was removed and now there are 13 votes. --Daniel Carrero (talk) 17:42, 31 August 2016 (UTC)Reply
I purged the page and it seems to have solved the problem. Andrew Sheedy (talk) 17:33, 31 August 2016 (UTC)Reply
The table is still broken for me. I'll try editing the module to automatically restrict the table to the first 10 votes or something and ignore later votes. The idea is that it's better to show the first 10 votes than show nothing. Naturally, when the first votes end and are removed from the table, the later votes will then appear in the table. I think that could work. --Daniel Carrero (talk) 17:41, 31 August 2016 (UTC)Reply

I think I was able to fix it. --Daniel Carrero (talk) 00:21, 1 September 2016 (UTC)Reply